Updated all dockerfiles with their latest base images. #5
Conversation
|
@Hyperclaw79 Have you tested that all of these microservices as working by pushing them to a cluster? |
|
I've tested a few. I'll let you know once I'm done with all the tests. |
csharp-aspnet/Dockerfile
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM microsoft/dotnet:1.1-sdk-msbuild | |||
| FROM microsoft/dotnet:latest | |||
There was a problem hiding this comment.
@Hyperclaw79 Can you fix this to a version and not latest? Issue with latest is that if a new release with breaking change happens, it cause problems
There was a problem hiding this comment.
Yes, already fixed it.
serverless-functions/Dockerfile
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM python:2.7-alpine | |||
| FROM python:3.7.0a3-alpine3.7 | |||
There was a problem hiding this comment.
Changing python2 to python3 is not a good idea. This will require code changes too.
There was a problem hiding this comment.
Yes, that makes sense. In fact, I was wondering about this; whether to port the entire code to Py3+ because that would open up possibilities for improvements and more features. But I guess, for now I'll switch it back to Py2 and I will re-edit it if I make a PR for the Py3 porting too.
Hyperclaw79
left a comment
Hyperclaw79
left a comment
There was a problem hiding this comment.
Fixed the images.
* Latest compatible version for base image * Superuser fix for composer * Removed redundant composer install
|
@Hyperclaw79 I think this is good to go. Can you fix the php-laravel/Dockerfile conflict? I think the latest php-laravel/Dockerfile that is on master works. Ccan merge the latest upstream master into your branch and update the PR? This is a great PR! Let's merge it quickly :) |
|
@coco98 Done sir. :) |
|
@shahidhk Any updates on this? I can close it if it irrelevant now. |
|
We're deprecating microservice-templates (you might have seen the warnings
on CLI). Thanks for then PR though. We'll test it and merge. Don't close.
Regards,
Shahidh
…On Tue, 29 May 2018 at 21:42, Harshith Thota ***@***.***> wrote:
@shahidhk <https://github.com/shahidhk> Any updates on this? I can close
it if it irrelevant now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AD7wPVMcj8-vSTVwKd3qJGb29p5EqXu7ks5t3XNqgaJpZM4RQsUm>
.
|
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.8) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.8) Signed-off-by: dependabot[bot] <[email protected]>
…ravel/app/ini-1.3.8 Bump ini from 1.3.5 to 1.3.8 in /php-laravel/app
…app/ini-1.3.8 Bump ini from 1.3.5 to 1.3.8 in /react/app
3 participants
No description provided.